Review Request 130031: Added Notification icons

[Albert Vaca Cintora]

> On mar. 20, 2017, 4:22 a.m., Aleix Pol Gonzalez wrote:
> > plugins/notifications/notificationsdbusinterface.cpp, line 94
> > <https://git.reviewboard.kde.org/r/130031/diff/2/?file=493544#file493544line94>
> >
> >     Can we find a non-blocking implementation?
> 
> Nicolas Fella wrote:
>     We certainly can. Changing to job->start() is not enough, however, it would require some extra work. I'll stick to it

I don't think we need to discard this, but I agree we need a non-blocking approach: right now if it takes long to transfer an image the UI is frozen meanwhile.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130031/#review102912
-----------------------------------------------------------


On mar. 26, 2017, 10:59 a.m., Nicolas Fella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130031/
> -----------------------------------------------------------
> 
> (Updated mar. 26, 2017, 10:59 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Added Notification icons
> 
> If the Network Package contains the notification Icon it is displayed. See corresponding patch on Android Repo
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/notificationsdbusinterface.cpp dbd63099f7fd41aeb730cbda78036888ef1a5a18 
> 
> Diff: https://git.reviewboard.kde.org/r/130031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas Fella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170327/9289fd80/attachment.html>