Review Request 130031: Added Notification icons

Aleix Pol Gonzalez aleixpol at kde.org
Mon Mar 20 11:22:46 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130031/#review102912
-----------------------------------------------------------




plugins/notifications/notificationsdbusinterface.cpp (line 93)
<https://git.reviewboard.kde.org/r/130031/#comment68501>

    Can we find a non-blocking implementation?


- Aleix Pol Gonzalez


On mar. 19, 2017, 3:51 p.m., Nicolas Fella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130031/
> -----------------------------------------------------------
> 
> (Updated mar. 19, 2017, 3:51 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Added Notification icons
> 
> If the Network Package contains the notification Icon it is displayed. See corresponding patch on Android Repo
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/notificationsdbusinterface.cpp dbd63099f7fd41aeb730cbda78036888ef1a5a18 
> 
> Diff: https://git.reviewboard.kde.org/r/130031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas Fella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170320/518dc44a/attachment-0001.html>


More information about the KDEConnect mailing list