Review Request 129980: [kdeconnect-android] Add swipe to refresh to device pairing activity

Albert Vaca Cintora albertvaka at gmail.com
Sat Mar 18 01:14:06 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129980/#review102896
-----------------------------------------------------------


Ship it!




Looks good! We will include it in the next release.

- Albert Vaca Cintora


On March 15, 2017, 11:24 p.m., Zixing Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129980/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 11:24 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Add swipe to refresh to device pairing activity
> 
> This makes it more conform to material design standard
> 
> 
> Diffs
> -----
> 
>   res/layout/activity_refresh_list.xml PRE-CREATION 
>   res/menu/pairing.xml ffc8c14 
>   res/menu/refresh.xml b37cec1 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java c2fe9c7 
>   src/org/kde/kdeconnect/UserInterface/PairingFragment.java c5fe622 
> 
> Diff: https://git.reviewboard.kde.org/r/129980/diff/
> 
> 
> Testing
> -------
> 
> Built and tested thoroughly on an Android 7.1.1 (API Level 25) device
> 
> 
> Thanks,
> 
> Zixing Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170318/ccfff724/attachment.html>


More information about the KDEConnect mailing list