Review Request 130015: Keep sshfs connection alive

[Albert Vaca Cintora]

> On mar. 15, 2017, 9:10 a.m., Aleix Pol Gonzalez wrote:
> > Looks a bit random? Where's this 30 coming from? Do we know why reconnect doesn't work?
> 
> Albert Vaca Cintora wrote:
>     I think the 30 is okay, but I'm also curious about why reconnect doesn't work. Actually, I don't even know what reconnect is supposed to do in the first place: the sshfs man page is really unspecific :/
> 
> Yuxuan Shui wrote:
>     It indeed is quite unspecific..
>     
>     My guess is 'reconnect' won't try to reconnect if the disconnection is intentional, e.g. initiate by the server after inactivity.
>     
>     Probably need to dig into ssh's code to figure out what's really happening.

It would be nice if you can figure it out :)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130015/#review102860
-----------------------------------------------------------


On mar. 15, 2017, 11:48 a.m., Yuxuan Shui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130015/
> -----------------------------------------------------------
> 
> (Updated mar. 15, 2017, 11:48 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Bugs: 377040
>     http://bugs.kde.org/show_bug.cgi?id=377040
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Add keep alive options to sshfs. I did a bit of testing after adding -o reconnect, turns out that's not enough.
> 
> 
> Diffs
> -----
> 
>   plugins/sftp/mounter.cpp 322a537 
> 
> Diff: https://git.reviewboard.kde.org/r/130015/diff/
> 
> 
> Testing
> -------
> 
> Mounted sshfs and waited for >10min, it's still mounted
> 
> 
> Thanks,
> 
> Yuxuan Shui
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170315/5090fa28/attachment.html>