Review Request 129993: Fix SFTP unmount

[Yuxuan Shui]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129993/
-----------------------------------------------------------

(Updated March 15, 2017, 11:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

Submitted with commit f2925b7661d952c040d76c1bef8a7db2bea7fbac by Albert Vaca on behalf of Yuxuan Shui to branch master.


Bugs: 377040
    http://bugs.kde.org/show_bug.cgi?id=377040


Repository: kdeconnect-kde


Description
-------

The destructor of Mounter says it doesn't call unmount because it will crash.

I tracked down the root cause of that. In unmount(), m_proc is set to nullptr before the process is killed. And Stderr/StdoutReadReady is triggered after that. So in the signal handler there's a nullptr dereference.

In this patch I take some actions to make sure the process is shutdown properly.


Diffs
-----

  plugins/sftp/mounter.h a9edc26 
  plugins/sftp/mounter.cpp f43a445 

Diff: https://git.reviewboard.kde.org/r/129993/diff/


Testing
-------


Thanks,

Yuxuan Shui

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170315/788ed41e/attachment.html>