D6089: Show no notification icon if there is no

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jun 5 09:28:21 UTC 2017


apol added a comment.


  Also note there's 2 unrelated white-space changes.

INLINE COMMENTS

> notification.cpp:105
>      if (!mHasIcon) {
> -        mNotification->setIconName(QStringLiteral("preferences-desktop-notification"));
> +        mNotification->setIconName(QStringLiteral("none"));
>          show();

`QString()`?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6089

To: nicolasfella, #kde_connect
Cc: apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170605/fa5c1594/attachment.html>


More information about the KDEConnect mailing list