D6724: Replace Q_FOREACH with C++11 range-for

[Jean Vincent]

jeanv added a comment.


  In https://phabricator.kde.org/D6724#125760, @nicolasfella wrote:
  
  > > except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it
  >
  > This seems to be just really bad naming. d is also the name of a member variable. The Device* should be renamed to avoid such confusion
  
  
  That's what I thought, but I wasn't sure so I didn't touch it. Thanks for clarifying
  
  I'll update the diff with the Q_FOREACH removed (and the name changed).

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6724

To: jeanv, #kde_connect, nicolasfella
Cc: nicolasfella, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170715/cffa7ce8/attachment.html>