D6089: Show no notification icon if there is no

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Maybe just change "none" to something like "nonexistent_icon_name_so_we_display_nothing", so it's more obvious this is not a hidden feature of KNotification or something...

INLINE COMMENTS

> apol wrote in notification.cpp:105
> Meh. Not your fault then.
> 
> Can you at least add a comment saying so?

https://media.giphy.com/media/a9xhxAxaqOfQs/giphy.gif

https://media.giphy.com/media/BEob5qwFkSJ7G/giphy.gif

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6089

To: nicolasfella, #kde_connect, albertvaka
Cc: albertvaka, apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170710/092c3c75/attachment-0001.html>