D6613: SharePlugin refactoring

[Albert Vaca Cintora]

albertvaka added a comment.


  Looks much better! Ship it!

INLINE COMMENTS

> SharePlugin.java:258
> +                } catch (Exception e) {
> +                    successful = false;
> +                    Log.e("SharePlugin", "Receiver thread exception");

It seems that the successful variable is not needed, you can pass false to setFinished when called from within the 'catch' block.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D6613

To: nicolasfella, #kde_connect
Cc: albertvaka, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170710/9d2494a1/attachment.html>