[Differential] [Commented On] D4206: Improve how we deal with dbus errors from the cli

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> kdeconnect-cli.cpp:41
> +    if (reply.isError()) {
> +        QTextStream(stderr) << i18n("error: ") << reply.error().message() << endl;
> +    }

Maybe return an empty T() here? Otherwise, I think QDbus goes loco and returns the error message as the value. Would be nice if you can test it first, maybe it's no longer the case?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D4206

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kde_connect, albertvaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170119/64f73e04/attachment.html>