D8957: Add title, artist and album to MPRIS network packets
Nicolas Fella
noreply at phabricator.kde.org
Thu Dec 28 14:45:50 UTC 2017
nicolasfella added inline comments.
INLINE COMMENTS
> mpriscontrolplugin.cpp:269
>
> +void MprisControlPlugin::insertPlayingInformation(NetworkPackage& np, const QVariantMap& nowPlayingMap) const {
> + QString title = nowPlayingMap[QStringLiteral("xesam:title")].toString();
i would prefer something like
insertPlayingInformation(NetworkPackage& target, const QVariantMap& source)
to make it more clear which one is the source/target. Or make the method name more clear
REPOSITORY
R224 KDE Connect
REVISION DETAIL
https://phabricator.kde.org/D8957
To: mtijink, #kde_connect, apol
Cc: nicolasfella, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171228/879f12ff/attachment.html>
More information about the KDEConnect
mailing list