D8957: Add title, artist and album to MPRIS network packets

Matthijs Tijink noreply at phabricator.kde.org
Thu Dec 21 12:21:15 UTC 2017


mtijink marked 7 inline comments as done.
mtijink added inline comments.

INLINE COMMENTS

> nicolasfella wrote in mpriscontrolplugin.cpp:146
> Please check whether it's really necessary to set it to an empty string or it's the default case. I'm not sure about that right now :)

It's necessary, since the code is written to send only changes in the network packets. If we don't send an empty artist etc. the Android part will think it's unchanged. With the current code it implicitely sends empty values, which is better.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D8957

To: mtijink, #kde_connect, apol
Cc: nicolasfella, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171221/97b4f4f3/attachment.html>


More information about the KDEConnect mailing list