D8161: findmyphone: Turn on camera flash as well

[Matthijs Tijink]

mtijink added a comment.


  In https://phabricator.kde.org/D8161#165243, @apol wrote:
  
  > In https://phabricator.kde.org/D8161#153854, @nicolasfella wrote:
  >
  > > Since it's only an optional Permission IMHO it would be okay to ask for it and provide an explanation. The user can still decline it if unwanted.
  >
  >
  > When will the user decide if she wants the flash to trigger when there's an alarm?
  
  
  Like with other optional permissions, it's shown in the list of controls for a paired device. So you can decide beforehand if you want the functionality (and grant camera permissions) or not.
  
  I think the functionality is a nice addition. That being said, it does not work for me (even after granting permission). I only get the following messages in the logcat:
  
    E/MediaPlayer-JNI: JNIMediaPlayerFactory: bIsQCMediaPlayerPresent 0
    E/MediaPlayer-JNI: JNIMediaPlayerFactory: bIsQCMediaPlayerPresent 0
    D/MediaPlayer: setSubtitleAnchor in MediaPlayer
    D/Ringtone: Successfully created local player
    E/MediaPlayer-JNI: JNIMediaPlayerFactory: bIsQCMediaPlayerPresent 0
    E/MediaPlayer-JNI: JNIMediaPlayerFactory: bIsQCMediaPlayerPresent 0
    D/MediaPlayer: setSubtitleAnchor in MediaPlayer
    D/Ringtone: Successfully created local player

INLINE COMMENTS

> AndroidManifest.xml:37
> +    <uses-permission android:name="android.permission.CAMERA" />
> +    <uses-permission android:name="android.permission.FLASHLIGHT" />
> +

Does such a permission exist? It's not in the list at https://developer.android.com/reference/android/Manifest.permission.html

> arjun wrote in strings.xml:219
> Like what?
> "If you want the flash to turn on while ringing, please grant access to the camera"
> ?

Something like "To turn on the flashlight in the find-my-phone functionality, you need to give permission to access the phone's camera" seems good to me. It emphasizes for what the functionality is needed, and should make it clearer what happens if you deny the permission.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D8161

To: arjun, #kde_connect
Cc: mtijink, nicolasfella, albertvaka, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171220/d19c5e00/attachment.html>