Review Request 130033: Added Notification icons

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130033/#review103004
-----------------------------------------------------------


Ship it!




Looks good to me, thanks a lot! Do you have permission to push to the repo? Otherwise I will push it on your behalf, and later on if you keep submitting patches you can request push access :)

- Albert Vaca Cintora


On March 26, 2017, 11:39 a.m., Nicolas Fella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130033/
> -----------------------------------------------------------
> 
> (Updated March 26, 2017, 11:39 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Added Notification icons
> 
> Some addidional fields are transfered in a network package. This includes the payloads MD5 checksum (which determines where the image file is stored) and the notifications title and text (which allows more flexibility in the desktop app, ticker is still transfered for compatibility)
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java e983bc4f7ab748bc2409db779214acb31a9608fd 
> 
> Diff: https://git.reviewboard.kde.org/r/130033/diff/
> 
> 
> Testing
> -------
> 
> Tested on LineageOS device (API Level 25)
> 
> 
> Thanks,
> 
> Nicolas Fella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170408/517fb00c/attachment.html>