Review Request 129076: sort commands by name on load

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 29 22:41:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129076/#review99677
-----------------------------------------------------------



Or maybe it could make sense to directly ask the view to sort it.


plugins/runcommand/runcommand_config.cpp (line 97)
<https://git.reviewboard.kde.org/r/129076/#comment67019>

    QStandardItemModel has a sort method, AFAIR.


- Aleix Pol Gonzalez


On Sept. 29, 2016, 3:13 p.m., Thomas Posch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129076/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 3:13 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Bugs: 369239
>     http://bugs.kde.org/show_bug.cgi?id=369239
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> load into a temporary array, sort, and add to tableView
> 
> 
> Diffs
> -----
> 
>   plugins/runcommand/runcommand_config.cpp 8f465bc 
> 
> Diff: https://git.reviewboard.kde.org/r/129076/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Posch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160929/ad23f831/attachment.html>


More information about the KDEConnect mailing list