Review Request 128861: [kdeconnect-kde] Fix division by null and use elapsed timer

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128861/#review99018
-----------------------------------------------------------


Ship it!




Awesome, thanks for the fix!

- Albert Vaca Cintora


On Sept. 8, 2016, 11:55 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128861/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 11:55 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> When sending multiple files from my phone to my PC I kdeconnectd usually got a SIGFPE. To get the transfer speed it divides the number of bytes received by the elapsed time which can be zero.
> 
> Also, since we're only interested in the time that has elapsed, use QElapsedTimer, which is exactly for this.QTime::elapsed also needs to take into account potential,y ocurred timezone / DST changes.
> 
> 
> Diffs
> -----
> 
>   core/filetransferjob.h ee434de 
>   core/filetransferjob.cpp 9ee8205 
> 
> Diff: https://git.reviewboard.kde.org/r/128861/diff/
> 
> 
> Testing
> -------
> 
> I can copy a bunch of files without crashing now.
> 
> I didn't actually test whether the remaining time returned is still sensible since I never get to actually see the dialog since it's all so fast.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160909/cd93a576/attachment.html>