Review Request 128607: Use KDE_INSTALL_FULL_LIBEXECDIR in kdeconnectd.desktop template

Aleix Pol Gonzalez aleixpol at kde.org
Sat Sep 3 08:55:33 UTC 2016



> On Aug. 5, 2016, 3:53 p.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Aleix Pol Gonzalez wrote:
>     Push to 1.0 branch
> 
> Antonio Rojas wrote:
>     Sorry, this slipped to my spam folder. Please commit it, I don't have a dev account.

I will, meanwhile you request a develoqper account.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128607/#review98143
-----------------------------------------------------------


On Aug. 5, 2016, 9:18 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128607/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 9:18 a.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This always translates to the correct path, while ${LIBEXEC_INSTALL_DIR} gives the wrong Exec=lib/kdeconnectd if KDE_INSTALL_LIBEXECDIR=lib.
> 
> 
> Diffs
> -----
> 
>   daemon/kdeconnectd.desktop.cmake 5051a43 
> 
> Diff: https://git.reviewboard.kde.org/r/128607/diff/
> 
> 
> Testing
> -------
> 
> Compiled with -DKDE_INSTALL_LIBEXECDIR=lib, Exec line in kdeconnectd.desktop points to /usr/lib/kdeconnectd instead of lib/kdeconnectd
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160903/cdaccb0f/attachment.html>


More information about the KDEConnect mailing list