Review Request 127297: Send the contact photo if any

Àlex Fiestas afiestas at kde.org
Mon Mar 7 10:39:12 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127297/
-----------------------------------------------------------

(Updated March 7, 2016, 11:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 17d5eeade0b92dbcb5b192ac6b17c1ef73ca1f95 by Àlex Fiestas to branch master.


Repository: kdeconnect-android


Description
-------

Send the contact photo as base64 within the same packet if the contact has any. If I am not mistaken the photo is always 96x96 or some other low resolution that matches the device DPI so it shouldn't be to big.


Diffs
-----

  src/org/kde/kdeconnect/Helpers/ContactsHelper.java a5b2713 
  src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java 99e3e27 

Diff: https://git.reviewboard.kde.org/r/127297/diff/


Testing
-------

Used the AVD to simulate a call from different phone numnbers, some I had photo some I did not. Did the same with sms.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160307/ea97effb/attachment.html>


More information about the KDEConnect mailing list