Review Request 127298: If the package contains a photo, show it in the notification

Aleix Pol Gonzalez aleixpol at kde.org
Mon Mar 7 10:27:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127298/#review93248
-----------------------------------------------------------



+1

- Aleix Pol Gonzalez


On March 6, 2016, 10:06 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127298/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 10:06 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> If the received packet has a photo, set it as pixmap in the notification, otherwise keep showing the icon.
> 
> 
> Diffs
> -----
> 
>   plugins/telephony/telephonyplugin.cpp c774c41 
> 
> Diff: https://git.reviewboard.kde.org/r/127298/diff/
> 
> 
> Testing
> -------
> 
> Simulated calls with and without photo, both worked.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160307/32b64cc9/attachment-0001.html>


More information about the KDEConnect mailing list