Review Request 127297: Send the contact photo if any

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127297/#review93243
-----------------------------------------------------------



Looks good to me. Just one addition.


src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java (line 190)
<https://git.reviewboard.kde.org/r/127297/#comment63575>

    Else np.set("contactName", phoneNumber) 
    
    So we keep the same behavior as before if we fail to retrieve the name.


- Albert Vaca Cintora


On March 6, 2016, 1:03 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127297/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 1:03 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Send the contact photo as base64 within the same packet if the contact has any. If I am not mistaken the photo is always 96x96 or some other low resolution that matches the device DPI so it shouldn't be to big.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Helpers/ContactsHelper.java a5b2713 
>   src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java 99e3e27 
> 
> Diff: https://git.reviewboard.kde.org/r/127297/diff/
> 
> 
> Testing
> -------
> 
> Used the AVD to simulate a call from different phone numnbers, some I had photo some I did not. Did the same with sms.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160306/849934e3/attachment.html>