Review Request 128273: MPRIS: Read list of allowed actions for the player, and enforce restrictions. (Android)

[Albert Vaca Cintora]

> On jun. 28, 2016, 1:42 p.m., Kai Uwe Broulik wrote:
> > I think previous/pause/next should still be shown but disabled/grayed out.
> > At least that's what we do in Plasma and what all players I know do.
> 
> Saikrishna Arcot wrote:
>     I initially did that, but visually, there was no difference between disabled buttons and enabled buttons.

That's probably because our buttons are already gray :P Maybe we can choose another color for the buttons (orange like the action bar?), and make them gray when disabled?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128273/#review96938
-----------------------------------------------------------


On jun. 28, 2016, 1:43 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128273/
> -----------------------------------------------------------
> 
> (Updated jun. 28, 2016, 1:43 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Read list of allowed actions for the player sent from KDE, and hide buttons that perform actions that aren't allowed based on MPRIS.
> 
> KDE side of change is in /r/128271.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 8905d14c88c01a272001f7ddeb53f744305602b2 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 962d9df11eb268e4651442c10c88f16d0fb471cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128273/diff/
> 
> 
> Testing
> -------
> 
> Tested with VLC and a client I'm working on that only supports pausing and skipping to the next track.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160629/19469c6e/attachment.html>