Review Request 128287: Use List interface in NetworkPackage

Albert Vaca Cintora albertvaka at gmail.com
Tue Jun 28 19:50:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128287/#review96932
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Vaca Cintora


On jun. 25, 2016, 6:30 a.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128287/
> -----------------------------------------------------------
> 
> (Updated jun. 25, 2016, 6:30 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Allow any type of list to be passed into NetworkPackage, and change return types to use `List` interface as well.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Device.java ebd2f3df0f780ed683380ba422fd6a962636360f 
>   src/org/kde/kdeconnect/NetworkPackage.java ef5b90e6c12357ba7498504ebe90819d5c53e77e 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 8905d14c88c01a272001f7ddeb53f744305602b2 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 962d9df11eb268e4651442c10c88f16d0fb471cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128287/diff/
> 
> 
> Testing
> -------
> 
> Verified that it compiles.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160628/2d57d192/attachment.html>


More information about the KDEConnect mailing list