Review Request 128271: MPRIS: Send info about whether certain actions are allowed. (KDE)

[Saikrishna Arcot]

> On June 21, 2016, 6:11 p.m., Aleix Pol Gonzalez wrote:
> > plugins/mpriscontrol/mpriscontrolplugin.cpp, line 245
> > <https://git.reviewboard.kde.org/r/128271/diff/2/?file=469710#file469710line245>
> >
> >     Is it really a problem if it's sent even though it's not allowed?

No, the client will just respond back on DBus with an error message.

Do you want me to take out the checks?


- Saikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128271/#review96788
-----------------------------------------------------------


On June 21, 2016, 1:42 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128271/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 1:42 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Send info about whether or not the player can play, pause, go back/forward or seek. The remote side can then disable some actions as necessary.
> 
> Also add a few checks locally to make sure that the command received is valid for this player (as per MPRIS).
> 
> Android side of change is in /r/128273.
> 
> 
> Diffs
> -----
> 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp c83ffb09fa1e36142e83a31cb3bf02f57262b6f4 
> 
> Diff: https://git.reviewboard.kde.org/r/128271/diff/
> 
> 
> Testing
> -------
> 
> Tested with VLC and a client I'm working on that only supports pausing and skipping to the next track.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160622/b49522ec/attachment.html>