Review Request 128149: RFC: Move the Telepathy infrastructure at the plugin level

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128149/
-----------------------------------------------------------

(Updated June 18, 2016, 9:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect and David Edmundson.


Changes
-------

Submitted with commit a4655770051f8f12017bf2f83435582c8be7dbc3 by David Edmundson on behalf of Aleix Pol Gonzalez to branch master.


Repository: kdeconnect-kde


Description
-------

At the moment, telepathy integration needs to be compiled within the daemon. This creates a rather aggressive dependency with Telepathy.

This plugin proposes to move into a plugin, so that if the plugin isn't present, telepathy becomes out of the picture.

David: I'm not really sure how well it's going to work, I'm relying on your feedback on how to proceed.


Diffs
-----

  CMakeLists.txt b778ff9 
  daemon/CMakeLists.txt 359ea8d 
  daemon/kdeconnectd.cpp 1b7a841 
  plugins/telephony/CMakeLists.txt 666c54f 
  plugins/telephony/telephonyplugin.h d1a6873 
  plugins/telephony/telephonyplugin.cpp d285c39 
  telepathy-cm/CMakeLists.txt fc763fb 
  telepathy-cm/connectcm_export.h 740ae98 
  telepathy-cm/connection.h b4438bf 
  telepathy-cm/kdeconnect.manager fcdeb08 
  telepathy-cm/kdeconnecttelepathyprotocolfactory.h 51b44fd 
  telepathy-cm/kdeconnecttelephony.manager PRE-CREATION 
  telepathy-cm/main.cpp PRE-CREATION 
  telepathy-cm/protocol.h 5431aa8 
  telepathy-cm/textchannel.h 3781283 

Diff: https://git.reviewboard.kde.org/r/128149/diff/


Testing
-------

Builds


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160618/87061677/attachment.html>