Review Request 128199: Add album art support for mpris plugin

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128199/#review96544
-----------------------------------------------------------


Ship it!





plugins/mpriscontrol/mpriscontrolplugin.cpp (line 153)
<https://git.reviewboard.kde.org/r/128199/#comment65223>

    Remove log message?



plugins/mpriscontrol/mpriscontrolplugin.cpp (line 159)
<https://git.reviewboard.kde.org/r/128199/#comment65224>

    ba -> imageBufferArray ? Or some more descriptive variable name.


- Albert Vaca Cintora


On jun. 15, 2016, 12:26 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128199/
> -----------------------------------------------------------
> 
> (Updated jun. 15, 2016, 12:26 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Right now we only support album art if the player provides a local URL, but some players provide a remote URL (spotify) I'll be adding support for that in a later patch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b778ff9 
>   plugins/mpriscontrol/CMakeLists.txt 5203f1f 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp 21b8abe 
> 
> Diff: https://git.reviewboard.kde.org/r/128199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160615/14140a29/attachment-0001.html>