Review Request 124140: Ported over to Netty and added SSL support

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124140/
-----------------------------------------------------------

(Updated June 6, 2016, 9:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect, Albert Vaca Cintora and Siddharth Sharma.


Repository: kdeconnect-android


Description
-------

* Since MINA was tying hands in adding SSL, ported over Netty which has a good, clean and easy interface and a larger user and developer base.
* Added support to setup links on SSL
* Links automatically removed if wrong certificate is sent
* Shows keys based on hash of certificate to check right certificates are received
* Added a preference to use SSL, as it is experienced to cause high CPU usage on devices.
* Corrected unit tests, LanLinkProvider is removed as it is nearly impossible to write it with current design. Will find a way


Diffs
-----

  build.gradle b36cf14 
  libs/netty-handler.jar PRE-CREATION 
  proguard-rules.pro ac9cda5 
  res/values/strings.xml c128342 
  src/org/kde/kdeconnect/Backends/BaseLink.java 53407f0 
  src/org/kde/kdeconnect/Backends/BasePairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java c070126 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java 0cb1ee3 
  src/org/kde/kdeconnect/Backends/LanBackend/LanPairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java add92f8 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java bd9c41b 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackPairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/BackgroundService.java 37baddb 
  src/org/kde/kdeconnect/Device.java a0b9392 
  src/org/kde/kdeconnect/Helpers/SecurityHelpers/RsaHelper.java PRE-CREATION 
  src/org/kde/kdeconnect/Helpers/SecurityHelpers/SslHelper.java PRE-CREATION 
  src/org/kde/kdeconnect/NetworkPackage.java a4ef7d0 
  src/org/kde/kdeconnect/UserInterface/DeviceActivity.java fe3c470 
  src/org/kde/kdeconnect/UserInterface/PairActivity.java 7a45751 
  tests/org/kde/kdeconnect/DeviceTest.java 5d3383d 
  tests/org/kde/kdeconnect/LanLinkProviderTest.java 0c1eb58 
  tests/org/kde/kdeconnect/LanLinkTest.java d3d94c9 
  tests/org/kde/kdeconnect/NetworkPackageTest.java a21114e 

Diff: https://git.reviewboard.kde.org/r/124140/diff/


Testing
-------

Tesed on some device with where both supports SSL, also with PC where ssl is not supported, working fine. Need a little bit more testing with more devices.


Thanks,

Vineet Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160606/a4be7312/attachment.html>