Review Request 128386: RFC: Make capabilities static

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128386/#review97157
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Vaca Cintora


On jul. 6, 2016, 8:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128386/
> -----------------------------------------------------------
> 
> (Updated jul. 6, 2016, 8:20 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> As discussed with Albert, move the population of capabilities into the identity package, making them static along the execution of the link.
> 
> When we receive the identityPackage, we collect the plugins we can use with the device and stick to those. This should simplify the implementation and remove the possibility to lose packages if packages are received before the capabilities are processed in the former approach.
> 
> 
> Diffs
> -----
> 
>   core/device.h f466856 
>   core/device.cpp ec2d1f5 
>   core/networkpackage.cpp 2498aa5 
>   core/networkpackagetypes.h 02f0e8b 
>   core/pluginloader.h f1722ab 
>   core/pluginloader.cpp 9608d46 
>   kcm/kcm.h 32fce5e 
>   kcm/kcm.cpp 72ebd93 
>   tests/pluginloadtest.cpp a663547 
> 
> Diff: https://git.reviewboard.kde.org/r/128386/diff/
> 
> 
> Testing
> -------
> 
> Not much.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160706/791e08be/attachment.html>