Review Request 126739: [GCI] Make a now playing label scroll horizontally.

[Mihail Ivchenko]

> On Jan. 14, 2016, 7:11 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java, line 461
> > <https://git.reviewboard.kde.org/r/126739/diff/1/?file=430634#file430634line461>
> >
> >     Why is this needed?
> 
> Mihail Ivchenko wrote:
>     Because TextView needs to be selected or focused. "Use setSelected" is most popular answer for "TextView marquee doesn't work" (for example: http://stackoverflow.com/a/8517252)
> 
> Albert Vaca Cintora wrote:
>     Does that mean that if you select a button or a slider, it will stop scrolling?

Right now it stops only after opening "players" dropdown. And it resumes when that dropdown is not shown. But since textview almost isn't visible while dropdown is shown I think that it's ok. Clicking on buttons\sliders doesn't disable scrolling now.


- Mihail


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126739/#review91044
-----------------------------------------------------------


On Jan. 14, 2016, 6:46 a.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126739/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 6:46 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Implements an automatic scroll on nowplaying label in case the text is longer than the label size (in a way similar to the marquee HTML tag).
> 
> Ellipsize="marquee" checks if text is actually too long to fit the label by itself, so no additional check is needed for that.
> 
> 
> Diffs
> -----
> 
>   res/layout/mpris_control.xml daba05a 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 371c2af 
> 
> Diff: https://git.reviewboard.kde.org/r/126739/diff/
> 
> 
> Testing
> -------
> 
> Tested on Nexus 5 running Android 6.0.1
> 
> 
> File Attachments
> ----------------
> 
> During animation
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/a7bbe896-ca30-435d-9f4c-ecafed1fc2b6__Screenshot_20160113-231057.png
> Without animations since text in short enought
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/2a9e9faa-c7cf-44ff-8ad9-e9a4b2690dfd__Screenshot_20160113-231020.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160116/f1c0bde8/attachment.html>