Review Request 126739: [GCI] Make a now playing label scroll horizontally.

Mihail Ivchenko ematirov at gmail.com
Thu Jan 14 02:46:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126739/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-android


Description
-------

Implements an automatic scroll on nowplaying label in case the text is longer than the label size (in a way similar to the marquee HTML tag).

Ellipsize="marquee" checks if text is actually too long to fit the label by itself, so no additional check is needed for that.


Diffs
-----

  res/layout/mpris_control.xml daba05a 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 371c2af 

Diff: https://git.reviewboard.kde.org/r/126739/diff/


Testing
-------

Tested on Nexus 5 running Android 6.0.1


File Attachments
----------------

During animation
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/a7bbe896-ca30-435d-9f4c-ecafed1fc2b6__Screenshot_20160113-231057.png
Without animations since text in short enought
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/2a9e9faa-c7cf-44ff-8ad9-e9a4b2690dfd__Screenshot_20160113-231020.png


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160114/64811a1f/attachment.html>


More information about the KDEConnect mailing list