Review Request 126722: notifications: also sync icon-data from notfication hints

[Holger Kaelberer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126722/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 6:18 p.m.)


Review request for kdeconnect.


Changes
-------

Use QBuffer instead of QTemporaryFile for image-data and friends.


Repository: kdeconnect-kde


Description
-------

- follows the priorities defined in the notifications spec version 1.2
- seems that payload can only be attached via QIODevices/files, therefore needed to create a temp file from the in-memory image data first; if there is another way - teach me pls!
- QDBusArgument-s can't be faked for testing without a real DBUS-call because they can be created either only for reading or for writing. Therefore added the virtual parseImageData function to use another datatype in the unit-tests


Diffs (updated)
-----

  plugins/notifications/notificationslistener.h dfa37b8 
  plugins/notifications/notificationslistener.cpp d21f3d7 
  tests/testnotificationlistener.cpp b43a7d3 

Diff: https://git.reviewboard.kde.org/r/126722/diff/


Testing
-------

sure


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160112/429940dd/attachment.html>