Review Request 126722: notifications: also sync icon-data from notfication hints

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126722/#review90948
-----------------------------------------------------------



plugins/notifications/notificationslistener.cpp (line 110)
<https://git.reviewboard.kde.org/r/126722/#comment62130>

    Maybe it would be easier if it returned a `QBuffer*` rather than a QFile?
    
    This way we don't need to get it in an actual file to read back.


- Aleix Pol Gonzalez


On Jan. 11, 2016, 9:05 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126722/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 9:05 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> - follows the priorities defined in the notifications spec version 1.2
> - seems that payload can only be attached via QIODevices/files, therefore needed to create a temp file from the in-memory image data first; if there is another way - teach me pls!
> - QDBusArgument-s can't be faked for testing without a real DBUS-call because they can be created either only for reading or for writing. Therefore added the virtual parseImageData function to use another datatype in the unit-tests
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/notificationslistener.h dfa37b8 
>   plugins/notifications/notificationslistener.cpp d21f3d7 
>   tests/testnotificationlistener.cpp b43a7d3 
> 
> Diff: https://git.reviewboard.kde.org/r/126722/diff/
> 
> 
> Testing
> -------
> 
> sure
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160112/5d7a892d/attachment.html>