Review Request 126666: Synchronize notification icons if possible and requested

[Holger Kaelberer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126666/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 7:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 4b5bde48589e5e45b57d97c0a28da6d0e918a8e7 by Holger Kaelberer to branch master.


Repository: kdeconnect-kde


Description
-------

Configurably attach icons as payload to notification packages. By design and due to restrictions on mobile devices *only* png is sent. As KIconLoader preferably returns svg  icons from iconPath() we fall back to loading from "hicolor" using KIconTheme directly. Otherwise *many* icons are dropped because of svg format.
    
This also improves slightly the test-case to use a tweaked TestDevice to allow for inspecting sent NetworkPackage-s.


Diffs
-----

  plugins/notifications/CMakeLists.txt 448be94 
  plugins/notifications/notifications_config.cpp 5086d9f 
  plugins/notifications/notifications_config.ui 3f3d8a4 
  plugins/notifications/notificationslistener.cpp 22d50fb 
  tests/CMakeLists.txt 66aeb5f 
  tests/testnotificationlistener.cpp e1faa1c 

Diff: https://git.reviewboard.kde.org/r/126666/diff/


Testing
-------

yep, works well with different android devices


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160111/d093866e/attachment.html>