Review Request 126667: Try to decode payload into largeIcon for notifications on Android

[Holger Kaelberer]

> On Jan. 11, 2016, 2:09 p.m., Albert Vaca Cintora wrote:
> > You might want to add a try catch block to cover the case getPayload contains something that decodeBitmap fails to understand.

Hm, BitmapFactory.decodeStream does not throw on error but returns null, which should be handled correctly.


- Holger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126667/#review90898
-----------------------------------------------------------


On Jan. 7, 2016, 7:01 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126667/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 7:01 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Newer API levels scale large icons in notifications automatically, olders don't. Therefore we downscale manually if necessary to avoid too big icons.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java e8391f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126667/diff/
> 
> 
> Testing
> -------
> 
> yep, works fine with desktop-notifications on all tested devices (S2/4.2.2, Galaxy Tab4/5.x, Galaxy Note3/5.0)
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160111/ee2325cd/attachment-0001.html>