Review Request 126666: Synchronize notification icons if possible and requested

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126666/#review90899
-----------------------------------------------------------

Ship it!


Looks good. Maybe in a future it might be a good idea to split the notifications plugin in two: one for sending and one for receiving. This way we slit the code into smaller files and also users can disable one or the other independently.

- Albert Vaca Cintora


On Jan. 7, 2016, 10:55 a.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126666/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 10:55 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Configurably attach icons as payload to notification packages. By design and due to restrictions on mobile devices *only* png is sent. As KIconLoader preferably returns svg  icons from iconPath() we fall back to loading from "hicolor" using KIconTheme directly. Otherwise *many* icons are dropped because of svg format.
>     
> This also improves slightly the test-case to use a tweaked TestDevice to allow for inspecting sent NetworkPackage-s.
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/CMakeLists.txt 448be94 
>   plugins/notifications/notifications_config.cpp 5086d9f 
>   plugins/notifications/notifications_config.ui 3f3d8a4 
>   plugins/notifications/notificationslistener.cpp 22d50fb 
>   tests/CMakeLists.txt 66aeb5f 
>   tests/testnotificationlistener.cpp e1faa1c 
> 
> Diff: https://git.reviewboard.kde.org/r/126666/diff/
> 
> 
> Testing
> -------
> 
> yep, works well with different android devices
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160111/e8f7d170/attachment.html>