Review Request 126273: Fix loosing already known plugins on reloading

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126273/#review90588
-----------------------------------------------------------

Ship it!


Looks like an actual bug to me! Maybe it would be better if addPlugin returns true when the plugin is already present, instead of adding the check before calling the function. Feel free to push it either way. Thanks a lot!

The capabilities feature is only active if both clients (KDE and Android) use git master, probably that's why most people was not affected by this bug.

- Albert Vaca Cintora


On des. 7, 2015, 1:10 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126273/
> -----------------------------------------------------------
> 
> (Updated des. 7, 2015, 1:10 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> I am having problems with latest git master's HEAD. Seems that a device's pluginsByIncomingInterface are lost after different events (like e.g. orientation changes), such that all plugin-specific incoming packets end up in nirvana. Is this known? Am I the only one with that problem?
> 
> This patch fixes the issue for me.
> 
> I'm not sure though, whether these repeated calls to reloadPluginsFromSettings() are to be blamed and fixed as root cause.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Device.java 697ea45 
> 
> Diff: https://git.reviewboard.kde.org/r/126273/diff/
> 
> 
> Testing
> -------
> 
> Yep, seems to fix the issue.
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160104/b0c5dce6/attachment.html>