Review Request 126997: Enable "move to SD"

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126997/#review92474
-----------------------------------------------------------



According to the Android Documentation [1], apps that (a) run as a service, and (b) launch at boot, should not be moved to the external storage as it will make the service to stop running in some cases. Since we need both things in KDE Connect, I think it's better if we don't allow moving it to the SD card. 

To mitigate the problem of phones with little internal storage, we try to maintain a small app size.

[1] http://developer.android.com/guide/topics/data/install-location.html

- Albert Vaca Cintora


On Feb. 6, 2016, 2:48 a.m., Javier Llorente wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126997/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 2:48 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> "Move to SD" is currently disabled. The attached patch enables it.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml aa9fbbb 
> 
> Diff: https://git.reviewboard.kde.org/r/126997/diff/
> 
> 
> Testing
> -------
> 
> kdeconnect built, installed and ran on a virtual device. The option "move to SD" is now enabled.
> 
> 
> Thanks,
> 
> Javier Llorente
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160216/6378310a/attachment.html>