[Differential] [Commented On] D3871: Reduce API exposed through dbus

[albertvaka (Albert Vaca Cintora)]

albertvaka added inline comments.

INLINE COMMENTS

> lockdeviceplugin.cpp:94
>  {
> -    QDBusConnection::sessionBus().registerObject(dbusPath(), this, QDBusConnection::ExportAllContents);
> +    QDBusConnection::sessionBus().registerObject(dbusPath(), this, QDBusConnection::ExportAllProperties);
>  

Why Properties instead of ExportScriptableInvokables? ring() should be able callable through dbus.

> remotecommandsplugin.cpp:62
>  {
> -    QDBusConnection::sessionBus().registerObject(dbusPath(), this, QDBusConnection::ExportAllContents);
> +    QDBusConnection::sessionBus().registerObject(dbusPath(), this, QDBusConnection::ExportAllProperties | QDBusConnection::ExportScriptableInvokables);
>  

What do you think about exposing always both things (properties and scriptableinvokables), even on plugins where there are no properties or no dbus slots? This way if we add any it will already work. Also, this is a line I tend to copy-paste when writing a new plugin, so it's better if it "just works" wherever I copy it from.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D3871

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, albertvaka, #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161231/89072cd3/attachment.html>