Review Request 128775: Use QSet::intersects() only when compiling with Qt 5.6 or newer

Albert Vaca Cintora albertvaka at gmail.com
Sun Aug 28 09:20:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128775/#review98737
-----------------------------------------------------------



I didn't like duplicating the code inside the "if", so I went for a different fix based on your code. I pushed it here: https://quickgit.kde.org/?p=kdeconnect-kde.git&a=commit&h=6281b9c232058759b21bf8e60c2f374fb5d42739

- Albert Vaca Cintora


On ago. 27, 2016, 10:18 a.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128775/
> -----------------------------------------------------------
> 
> (Updated ago. 27, 2016, 10:18 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> QSet.intersects() was introduced in Qt 5.6. Use alternative method that should work on Qt 5.2 or newer.
> 
> 
> Diffs
> -----
> 
>   core/pluginloader.cpp 0a908f594fa88642931a39b256124004dc8349b2 
> 
> Diff: https://git.reviewboard.kde.org/r/128775/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and pairs and works.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160828/57604a4d/attachment-0001.html>


More information about the KDEConnect mailing list