Review Request 128775: Replace QSet.intersects()

[Saikrishna Arcot]

> On Aug. 27, 2016, 5:15 a.m., Aleix Pol Gonzalez wrote:
> > I don't think that's better.
> > Code less readable, unneeded memory allocations.
> > 
> > I pushed a change to explicitly need Qt 5.6.

I see the change is in the 1.x branch. Could you also make the change on master?


- Saikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128775/#review98715
-----------------------------------------------------------


On Aug. 26, 2016, 8:46 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128775/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 8:46 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> QSet.intersects() was introduced in Qt 5.6. Use alternative method that should work on Qt 5.2 or newer.
> 
> 
> Diffs
> -----
> 
>   core/pluginloader.cpp 0a908f594fa88642931a39b256124004dc8349b2 
> 
> Diff: https://git.reviewboard.kde.org/r/128775/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and pairs and works.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160827/e31cec53/attachment.html>