Review Request 126722: notifications: also sync icon-data from notfication hints

[Holger Kaelberer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126722/
-----------------------------------------------------------

(Updated Aug. 22, 2016, 6:26 p.m.)


Review request for kdeconnect.


Changes
-------

- rebased against current master (sendnotifications)
- use QBuffer instead of temp-file
- prefer QVariant::canConvert over typeName()
- use smart pointers where possible
- warn on unsupported image-formats in notifications hints


Repository: kdeconnect-kde


Description
-------

- follows the priorities defined in the notifications spec version 1.2
- seems that payload can only be attached via QIODevices/files, therefore needed to create a temp file from the in-memory image data first; if there is another way - teach me pls!
- QDBusArgument-s can't be faked for testing without a real DBUS-call because they can be created either only for reading or for writing. Therefore added the virtual parseImageData function to use another datatype in the unit-tests


Diffs (updated)
-----

  plugins/sendnotifications/notificationslistener.h 0612c34 
  plugins/sendnotifications/notificationslistener.cpp 4da1770 
  tests/testnotificationlistener.cpp ad36dac 

Diff: https://git.reviewboard.kde.org/r/126722/diff/


Testing
-------

sure


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160822/dff981e2/attachment.html>