Review Request 127768: Don't hardcode app name to filter notifications

[David Kahles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127768/
-----------------------------------------------------------

(Updated April 28, 2016, 1:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 623ca94a0c2376cf4726f5b30f8ece9ed63658b1 by David Kahles to branch sslrefactor.


Repository: kdeconnect-kde


Description
-------

The app name used by KNotification is translated, and thus the filtering
doesn't work if the translated app name is different.

Previously, when the phone gets a new notification and sends it to the computer, kdeconnect will post
a notification, but record this notification (as the filtering didn't work) and send it back to the phone. Therefore each notification on the phone will there be two times.

This works on master because notifications aren't synchronized with the phone (a bug?). On sslrefactor this is fixed, and thus we need to fix the filtering.

I need to parse this configuration file, as I don't see another way to retrieve the translated app name.


Diffs
-----

  plugins/notifications/CMakeLists.txt d74cca6b249411d981a23fdf6ec5a493efd472e1 
  plugins/notifications/notificationslistener.h dfa37b8a914e8cd03e1bb3d3eaf8f4f66269ef02 
  plugins/notifications/notificationslistener.cpp d21f3d733752a155ea26f34bfab2b873f7e3de72 

Diff: https://git.reviewboard.kde.org/r/127768/diff/


Testing
-------

If the phone gets a notification, it will appear on the computer, but not again on the phone.
Sending notification from the computer to the phone still works fine.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160428/8f9354a5/attachment.html>