Review Request 127641: Don't reset m_pairStatus when unpair is requested by remote device

Aleix Pol Gonzalez aleixpol at kde.org
Tue Apr 12 23:45:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127641/#review94561
-----------------------------------------------------------


Ship it!




Good catch!

- Aleix Pol Gonzalez


On April 12, 2016, 9:37 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127641/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 9:37 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> unpairInternal() will take care of this, otherwise pairingChanged() will not
> be emited and though, the model won't notice it.
> 
> 
> Diffs
> -----
> 
>   core/device.cpp 816b37a56d1ba33de67ebbbd03f3b585ff86c291 
> 
> Diff: https://git.reviewboard.kde.org/r/127641/diff/
> 
> 
> Testing
> -------
> 
> Unpairing from the phone is now recognized by the plasmoid. Pairing, disconnecting and connecting still works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160412/bce1652d/attachment.html>


More information about the KDEConnect mailing list