Review Request 127610: Improve filtering of devices in the DevicesModel

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127610/#review94429
-----------------------------------------------------------


Ship it!




Looks good to me, thanks!


interfaces/devicesmodel.h (line 90)
<https://git.reviewboard.kde.org/r/127610/#comment64190>

    Maybe rename to isAcceptedByFilter, or passesFilter or something like that?


- Albert Vaca Cintora


On April 7, 2016, 1:57 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127610/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 1:57 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> We need to remove devices from the model if the filter doesn't match, to
> prevent listing disconnected devices in the plasmoid.
> 
> 
> Diffs
> -----
> 
>   interfaces/devicesmodel.h 283a41d72f5af61ef4bbb41c472414d539e0b629 
>   interfaces/devicesmodel.cpp af192c81405a08dfb1a8788bc852baff4ed5f66b 
> 
> Diff: https://git.reviewboard.kde.org/r/127610/diff/
> 
> 
> Testing
> -------
> 
> Now disconnected devices are removed from the plasmoid.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160408/ecd47c92/attachment.html>