Review Request 127611: Fix mpris player discovery

David Kahles david.kahles96 at gmail.com
Thu Apr 7 23:21:39 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127611/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

The previous used QDbusServiceWatcher doesn't work as it does only watch out
for specific services, but the players use different, unpredictable names, so
we need to check all service registrations for mpris players.

BUG: 361367


Diffs
-----

  plugins/mpriscontrol/mpriscontrolplugin.h e7839eba99cb3d918c1741c3e226a4da878cdc59 
  plugins/mpriscontrol/mpriscontrolplugin.cpp cc2fcde972ea224d68a332b563c0b0c97adf47eb 

Diff: https://git.reviewboard.kde.org/r/127611/diff/


Testing
-------

Previously, new launched players were not found, and quiting a player was unrecognized.
Now all players are recognized. I tested starting them before launching kdeconnectd and launching and quiting them when kdeconnectd is running.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160407/b3e42fa5/attachment-0001.html>


More information about the KDEConnect mailing list