Review Request 127582: Remove notifications from plasmoid, if the notifications plugin gets disabled

David Kahles david.kahles96 at gmail.com
Wed Apr 6 00:14:30 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127582/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

Therefore notify the client that we're deleting all notifications.
Otherwise the client wouldn't notice this and the notifications would still
be available in the plasmoid.

This is IHMO a better solution as https://git.reviewboard.kde.org/r/127544/


Diffs
-----

  interfaces/notificationsmodel.cpp 0844d03f78f500bfc1399870eb786043c68619d0 
  plugins/notifications/notificationsdbusinterface.cpp 2e9132b6b98c3466c27222d4f882ed0da2f49465 

Diff: https://git.reviewboard.kde.org/r/127582/diff/


Testing
-------

If i disabled the notification plugin, the notifications stayed in the plasmoid though they were purged in the server, because they were cached.
With this patch, the notifications disappear immediately.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160406/4865e787/attachment.html>


More information about the KDEConnect mailing list