Review Request 127565: Improve NotificationsModel

David Kahles david.kahles96 at gmail.com
Mon Apr 4 12:31:39 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127565/
-----------------------------------------------------------

(Updated April 4, 2016, 2:31 p.m.)


Review request for kdeconnect.


Changes
-------

Make id const and use initializer list


Repository: kdeconnect-kde


Description
-------

Don't refresh the whole notification list, if a notification is added or
removed.


Diffs (updated)
-----

  interfaces/dbusinterfaces.h b5705e684fae9b78f31c2a2a8e2f8bcf3dd085a8 
  interfaces/dbusinterfaces.cpp d0883f8be1f583f923238f9fea4f2feb8b6c4fe8 
  interfaces/notificationsmodel.cpp 20d242e3d7b19b0cc6e14f88135f77c5df4018a2 

Diff: https://git.reviewboard.kde.org/r/127565/diff/


Testing
-------

Adding notifications and removing notifications from the device and the plasmoid still works.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160404/14f2c3ca/attachment-0001.html>


More information about the KDEConnect mailing list