Review Request 127553: Allow paired and not reachable devices in the model

David Kahles david.kahles96 at gmail.com
Mon Apr 4 12:29:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127553/
-----------------------------------------------------------

(Updated April 4, 2016, 2:29 p.m.)


Review request for kdeconnect.


Changes
-------

Revert kcm change


Repository: kdeconnect-kde


Description
-------

The server supports this device state (e.g. if a device was saved as paired,
but isn't reachable), so let's expose it to the model.
The display filter should take care of excluding such devices if
nessecarry.
To make sure that such devices aren't shown in the kcm (we can't do anything
useful with them at the moment), set the display filter accordingly.

This makes the model more generic, we could e.g. introduce the possibility to remove saved devices
in the kcm.
Otherwise the behaviour of the model is a bit confusing, as the devices don't have the same
states as in the server.


Diffs (updated)
-----

  interfaces/devicesmodel.cpp 7b0fdbb77d0f6475c564a8f0f1a76e3cc2b5b158 

Diff: https://git.reviewboard.kde.org/r/127553/diff/


Testing
-------

Paired but unconnected devices are still not shown in the plasmoid or the kcm.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160404/c1f91175/attachment.html>


More information about the KDEConnect mailing list