Review Request 127565: Improve NotificationsModel

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127565/#review94227
-----------------------------------------------------------




interfaces/dbusinterfaces.h (line 105)
<https://git.reviewboard.kde.org/r/127565/#comment64103>

    Then you can make this const



interfaces/dbusinterfaces.cpp (line 91)
<https://git.reviewboard.kde.org/r/127565/#comment64102>

    Construct as an attribute: `Constructor::Constructor() : a(b) {}`


- Aleix Pol Gonzalez


On April 3, 2016, 5:01 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127565/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 5:01 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Don't refresh the whole notification list, if a notification is added or
> removed.
> 
> 
> Diffs
> -----
> 
>   interfaces/dbusinterfaces.h b5705e684fae9b78f31c2a2a8e2f8bcf3dd085a8 
>   interfaces/dbusinterfaces.cpp d0883f8be1f583f923238f9fea4f2feb8b6c4fe8 
>   interfaces/notificationsmodel.cpp 20d242e3d7b19b0cc6e14f88135f77c5df4018a2 
> 
> Diff: https://git.reviewboard.kde.org/r/127565/diff/
> 
> 
> Testing
> -------
> 
> Adding notifications and removing notifications from the device and the plasmoid still works.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160404/1acbcc38/attachment.html>