Review Request 127544: Remove notifications from plasmoid, if the notifications plugin gets disabled

[David Kahles]

> On April 1, 2016, 9:03 p.m., Aleix Pol Gonzalez wrote:
> > plasmoid/package/contents/ui/DeviceDelegate.qml, line 113
> > <https://git.reviewboard.kde.org/r/127544/diff/1/?file=454962#file454962line113>
> >
> >     Shouldn't we clear the notifications model when the notification plugin unloads?

Yes that sounds much cleaner.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127544/#review94194
-----------------------------------------------------------


On April 2, 2016, 3:41 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127544/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 3:41 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Therefore create a component which checks whether the plugin is loaded,
> and exposes this information to the DeviceDelegate. The code is mostly
> copied from FindMyPhone.qml.
> 
> 
> Diffs
> -----
> 
>   interfaces/notificationsmodel.h 0eb3a4debc1076c7e77b721d00d30a5c72b1ae89 
>   plasmoid/package/contents/ui/DeviceDelegate.qml 34dfb1952ed6973c8b3ce5b96fc4799ba37610d7 
>   plasmoid/package/contents/ui/NotificationsPluginChecker.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127544/diff/
> 
> 
> Testing
> -------
> 
> If i disabled the notification plugin, the notifications stayed in the plasmoid though they were purged in the server, because they were cached.
> With this patch, the notifications disappear immediately.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160402/b52aac44/attachment.html>