KDE Connect SSL

[vineet garg]

Hi

One problem what I found out that was causing tests to fail, is repeated
pair packages. The main cause for that was I was using LanPairingHandler
for LoopbackLink because functionality is same but this was causing errors
since the pair status is set in LanPairingHandler after sending pair
package successfully which is correct for LanPairingHandler but in Loopback
link, reply is received before setting pair status and it interprets as
pairing request. This happens in accept pairing method too, where also
status is set after sending pair package successfully causing an infinite
pair package loop in loopback link. I added a Loopback pairing handler
which inherits from LanPairingHandler and corrected these issue. Infinite
pair packages problem is solved but tests are still failing.  Plugin load
test is failing due to kdeconnect_remotecontrol plugin, and file transfer
test is failing with issue that there is no such signal fileReceived in
plugin. I am pushing changes to sslmaster with commit "Added loopback
pairing handler". @Aleix can you again look at those tests? @Albert, you
said that there are some problems in KDE to KDE, can tell me the specific
problems?

Vineet


On Sat, Sep 12, 2015 at 10:19 PM, vineet garg <grgvineet at gmail.com> wrote:

> Hi
>
> As Albert pointed out earlier that KDE to KDE has some problems, so I am
> setting another environment in virtual box to check it. It is taking some
> time. I will push it afterward.
>
> Vineet
>
> On Sat, Sep 12, 2015 at 8:10 PM, Aleix Pol <aleixpol at kde.org> wrote:
>
>> On Sat, Sep 12, 2015 at 4:08 PM, vineet garg <grgvineet at gmail.com> wrote:
>> > Hi
>> >
>> > I saw the tests and found out the issues. In one test
>> startServerEncryption
>> > and startClientEncryption was wrongly written, fixed that. In one
>> plugin the
>> > error is due to requestPairing since I was setting pairStatus after
>> sending
>> > package and loopback (which is using lan pairing handler) replies even
>> > before it is set causing an issue. Will add a loopback pairing handler.
>> > Plugin load test is also failing, will check that too. File transfer
>> plugin
>> > does not work completely in my laptop, can you confirm that unit tests
>> are
>> > passing because it is failing on my laptop and reason might be due to
>> > because plugin does not work correctly on my laptop.
>> >
>> > Vineet
>> >
>> > On Sat, Sep 12, 2015 at 6:00 PM, Albert Vaca <albertvaka at gmail.com>
>> wrote:
>> >>
>> >> Could you have a look at the tests?
>> >>
>> >> On Fri, Sep 11, 2015 at 9:58 AM, vineet garg <grgvineet at gmail.com>
>> wrote:
>> >>>
>> >>> Hi Albert,
>> >>> I was just working with netty folks to find out the issue with Android
>> >>> lollipop, I will look at it and see why test cases are not passing
>> because I
>> >>> committed only when all test cases passed.
>> >>>
>> >>> Vineet
>> >>>
>> >>> On Sep 11, 2015 10:23 PM, "Albert Vaca" <albertvaka at gmail.com> wrote:
>> >>>>
>> >>>> Hi Vineet,
>> >>>>
>> >>>> We have merged the ssl and master branches, because SSL was forked a
>> >>>> while back and hadn't had merges from master in the meanwhile.
>> >>>>
>> >>>> We got the SSL connection working from Android to Android with the
>> >>>> merged branch. It now has all the latest changes, like the Material
>> design,
>> >>>> plus the SSL link, and seems to be working fine.
>> >>>>
>> >>>> KDE to KDE, though, we are having some problems. We have seen that
>> the
>> >>>> tests you wrote are also not passing, which makes me think that
>> there is
>> >>>> something broken. Can you have a look?
>> >>>>
>> >>>> The merged branches are called "sslmaster", to not break the master
>> >>>> branch. Once we have it working there, we will merge that back into
>> master.
>> >>>>
>> >>>> Thanks,
>> >>>> Albert
>> >>
>> >>
>> >
>>
>> Hi,
>> You didn't push anything, can you push it to sslmaster?
>>
>> Aleix
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150914/7402721a/attachment.html>